I have also done both, but I preferred insanity only bc it was shorter & more intense. I lost 18lbs on it, p90x toned me up but i didn't lose any weight.
Also, I thankfully don't have any knee/ joint problems. There's tons of jumping in insanity so it's definitely not for everyone.
Good luck