I bet it's the lid. With canning you replace the lids each time you use the jar. The lids on those jars aren't meant to be kept and reused over and over.

Glass shouldn’t hold any kind of smell. Are you still using the same lid?

Vinegar soak overnight then run through dishwasher.

It's the lid - if you washed it well, glass shouldn't smell but the lid is made of different material. Try soaking that. Or just buy some cheap mason jars on Amazon.

Toss it and buy some glass canning jars instead.

I would guess vinegar too. Are you sure it still smells? That's unusual for glass. Is it the top maybe?

Vinegar soak maybe?

Let it air out?
Go ahead and put the stock in? I doubt it will be impacted.

I took a glass jar that had previously had tomato sauce from Trader Joe's and washed it out, peeled off the label, and wanted to use it for stuff - storing carrots, leftover stock, nuts, whatever. Except ... I can't get rid of the smell. I've soaked it in hot water and dish soap overnight multiple times and scrubbed it multiple times, all to no avail. What is the solution here?